Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport closure compiler fixes from internal #5480

Merged
merged 7 commits into from
Feb 6, 2019
Merged

Backport closure compiler fixes from internal #5480

merged 7 commits into from
Feb 6, 2019

Conversation

dfreedm
Copy link
Member

@dfreedm dfreedm commented Feb 6, 2019

No description provided.

rictic
rictic reviewed Feb 6, 2019
View reviewed changes
Copy link
Contributor

@rictic rictic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was this PR generated?

lib/mixins/dir-mixin.js Outdated Show resolved Hide resolved
lib/mixins/disable-upgrade-mixin.js Outdated Show resolved Hide resolved
lib/mixins/element-mixin.js Outdated Show resolved Hide resolved
lib/mixins/property-effects.js Outdated Show resolved Hide resolved
@dfreedm
Copy link
Member Author

dfreedm commented Feb 6, 2019

@rictic I merged shady-nopatch branch into google3, and did a diff with what was already there and manually did some massaging

@dfreedm
Copy link
Member Author

dfreedm commented Feb 6, 2019

After talking with @rictic, @suppress has to be before @license, but @fileoverview must be first in the comment block.

rictic
rictic approved these changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@rictic rictic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the @suppress lines are moved above the @licenenses

kevinpschaaf
kevinpschaaf approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@kevinpschaaf kevinpschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinpschaaf kevinpschaaf merged commit 9328274 into shady-nopatch Feb 6, 2019
@kevinpschaaf kevinpschaaf deleted the closure-compiler-fixes branch February 6, 2019 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpschaaf kevinpschaaf kevinpschaaf approved these changes

@rictic rictic rictic approved these changes

@sorvell sorvell Awaiting requested review from sorvell

@TimvdLippe TimvdLippe Awaiting requested review from TimvdLippe

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dfreedm @rictic @kevinpschaaf @googlebot