Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport closure compiler fixes from internal #5480

Merged
merged 7 commits into from
Feb 6, 2019
Merged

Backport closure compiler fixes from internal #5480

merged 7 commits into from
Feb 6, 2019

Commits on Feb 6, 2019

  1. Backport closure compiler fixes from internal

    @dfreedm
    dfreedm committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    e3c6b25 View commit details
    Browse the repository at this point in the history

  2. Ensure argument types match.

    @kevinpschaaf
    kevinpschaaf committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    42735d1 View commit details
    Browse the repository at this point in the history

  3. Refactor symbols to make gen-typescript-declarations happy

    @kevinpschaaf
    kevinpschaaf committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    4a24ba3 View commit details
    Browse the repository at this point in the history

  4. Remove semicolon after class definition (lint).

    @kevinpschaaf
    kevinpschaaf committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    ae899c5 View commit details
    Browse the repository at this point in the history

  5. use JSCompiler_renameProperty bare

    @dfreedm
    dfreedm committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    fb24656 View commit details
    Browse the repository at this point in the history

  6. address feedback

    @dfreedm
    dfreedm committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    4321da0 View commit details
    Browse the repository at this point in the history

  7. Add @fileoverview, put @suppress after it

    @dfreedm
    dfreedm committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    aba0f90 View commit details
    Browse the repository at this point in the history