Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse imports for file into one statement #5354

Merged
merged 1 commit into from
Sep 7, 2018
Merged

Conversation

rictic
Copy link
Contributor

@rictic rictic commented Sep 7, 2018

This is a warning in the internal build system, and it does make the code a bit easier to read this way.

no-op change

This is a warning in the internal build system, and it does make the code a bit easier to read this way.

no-op change
@TimvdLippe
Copy link
Contributor

This got recently modified in #5347 which resulted in a merge conflict 😢

@rictic
Copy link
Contributor Author

rictic commented Sep 7, 2018

Rebased, PTAL

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy fix, nice!

Copy link
Member

@kevinpschaaf kevinpschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rictic rictic merged commit 5290b83 into master Sep 7, 2018
@rictic rictic deleted the no-double-import branch September 7, 2018 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants