Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup modulizer conversion leftovers #5347

Merged
merged 1 commit into from
Sep 6, 2018
Merged

Cleanup modulizer conversion leftovers #5347

merged 1 commit into from
Sep 6, 2018

Conversation

web-padawan
Copy link
Contributor

@web-padawan web-padawan commented Aug 28, 2018 •
edited
Loading

This change is Reviewable

@web-padawan web-padawan changed the title Remove modulizer leftover in gesture-event-listeners Cleanup modulizer conversion leftovers Aug 31, 2018
TimvdLippe
TimvdLippe approved these changes Sep 5, 2018
View reviewed changes
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@TimvdLippe
Copy link
Contributor

@web-padawan Could you merge with master and fix the 1 linter error that was introduced in this PR? Then this is ready for merging! 😄

@web-padawan
Copy link
Contributor Author

@TimvdLippe fixed the linter error. Branch is rebased on top of master.

@TimvdLippe
Copy link
Contributor

Thanks again 😄

@TimvdLippe TimvdLippe merged commit 448093b into Polymer:master Sep 6, 2018
@web-padawan web-padawan deleted the patch-1 branch September 6, 2018 10:15
@TimvdLippe TimvdLippe mentioned this pull request Sep 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimvdLippe TimvdLippe TimvdLippe approved these changes

@dfreedm dfreedm Awaiting requested review from dfreedm

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

@sorvell sorvell Awaiting requested review from sorvell

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@web-padawan @TimvdLippe @googlebot