Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix impl of _contentForTemplate. Add template-stamp tests. #4623

Merged
merged 3 commits into from
May 27, 2017
Merged

Fix impl of _contentForTemplate. Add template-stamp tests. #4623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06190c9
Fix impl of _contentForTemplate. Add template-stamp tests.
kevinpschaaf May 23, 2017
02e31d7
Avoid firstElementChild on DocFrag for IE11
kevinpschaaf May 24, 2017
b73caea
Just ensure content frag from _contentForTemplate is inert.
kevinpschaaf May 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/mixins/template-stamp.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@
* @return {DocumentFragment} Content fragment
*/
static _contentForTemplate(template) {
let templateInfo = template.__templateInfo;
let templateInfo = template._templateInfo;
return (templateInfo && templateInfo.content) || template.content;
}

Expand Down
1 change: 1 addition & 0 deletions test/runner.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
var suites = [
'unit/globals.html',
'unit/property-accessors.html',
'unit/template-stamp.html',
'unit/property-effects.html',
'unit/property-effects-template.html',
'unit/path-effects.html',
Expand Down
99 changes: 99 additions & 0 deletions test/unit/template-stamp.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,99 @@
<!DOCTYPE html>
<!--
@license
Copyright (c) 2017 The Polymer Project Authors. All rights reserved.
This code may only be used under the BSD style license found at http://polymer.github.io/LICENSE.txt
The complete set of authors may be found at http://polymer.github.io/AUTHORS.txt
The complete set of contributors may be found at http://polymer.github.io/CONTRIBUTORS.txt
Code distributed by Google as part of the polymer project is also
subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt
-->
<html>
<head>
<meta charset="UTF-8">

<script src="../../../webcomponentsjs/webcomponents-lite.js"></script>
<script src="../../../web-component-tester/browser.js"></script>

<link rel="import" href="../../lib/mixins/template-stamp.html">
</head>
<body>

<template id="test-template" strip-whitespace>
<div id="a">a</div>
<div id="eventHandler" on-click="handleClick"></div>
<div id="b">b</div>
<template id="nestedTemplate">
<div on-click="handleClick"></div>
</template>
<template id="preservedTemplate" preserve-content>
<div on-click="shouldNotBeRemoved"></div>
</template>
</template>

<script>
HTMLImports.whenReady(() => {
class TemplateStamper extends Polymer.TemplateStamp(HTMLElement) {
connectedCallback() {
this.handleClick = sinon.spy(event => {
this.handleClickTarget = event.target;
});
let template = document.getElementById('test-template');
this.dom = this._stampTemplate(template);
this.attachShadow({mode:'open'}).appendChild(this.dom);
}
}
customElements.define('template-stamper', TemplateStamper);
});
</script>

<script>

suite('template-stamp', () => {

test('id map', () => {
let el = document.createElement('template-stamper');
document.body.appendChild(el);
assert.equal(el.dom.$.a.textContent, 'a');
assert.equal(el.dom.$.b.textContent, 'b');
document.body.removeChild(el);
});

test('declarative events', () => {
let el = document.createElement('template-stamper');
document.body.appendChild(el);
el.dom.$.eventHandler.click();
assert.equal(el.handleClick.callCount, 1);
assert.equal(el.handleClick.firstCall.args[0].type, 'click');
assert.equal(el.handleClickTarget, el.dom.$.eventHandler);
document.body.removeChild(el);
});

test('cached template content', () => {
let el = document.createElement('template-stamper');
document.body.appendChild(el);
let content = el.constructor._contentForTemplate(el.dom.$.nestedTemplate);
assert.isTrue(content instanceof DocumentFragment);
assert.notOk(content.ownerDocument.defaultView);
assert.equal(content.firstChild.getAttribute('on-click'), null);
document.body.removeChild(el);
});

test('preserved template content', () => {
let el = document.createElement('template-stamper');
document.body.appendChild(el);
let content = el.dom.$.preservedTemplate.content;
assert.isTrue(content instanceof DocumentFragment);
assert.equal(content.childNodes[1].getAttribute('on-click'), 'shouldNotBeRemoved');
document.body.removeChild(el);
});

});

// Note template parsing API is tested in `property-effects-template.html`,
// combined with adding property effects

</script>

</body>
</html>