Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix impl of _contentForTemplate. Add template-stamp tests. #4623

Merged
merged 3 commits into from
May 27, 2017
Merged

Fix impl of _contentForTemplate. Add template-stamp tests. #4623

merged 3 commits into from
May 27, 2017

Conversation

kevinpschaaf
Copy link
Member

Reference Issue

Fixes #4597

@kevinpschaaf kevinpschaaf requested a review from sorvell May 23, 2017 17:24
sorvell
sorvell approved these changes May 24, 2017
View reviewed changes
Copy link
Contributor

@sorvell sorvell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinpschaaf
Avoid firstElementChild on DocFrag for IE11
02e31d7
@kevinpschaaf
Just ensure content frag from _contentForTemplate is inert.
b73caea 
Edge does not seem to always use the exact same owner document for templates.
@sorvell sorvell merged commit 1b03448 into master May 27, 2017
@sorvell sorvell deleted the 4597-kschaaf-contentForTemplate branch May 27, 2017 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorvell sorvell sorvell approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinpschaaf @sorvell @googlebot