Fix custom-style-late tests #4503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The included element was never upgrading because it is an extension element, and CustomStyleInterface boots up async due to webcomponents/shadycss@33512fc and misses the resync. This is solved by making a real element. Also, this test wasn't really "late", so the `<custom-style>` is asynchronous now Fixes #4501
sorvell
reviewed
Apr 6, 2017
test/unit/custom-style-late.html
Outdated
| --cs-blue: { | ||
| border: 8px solid blue; | ||
| } | ||
| ; |
There was a problem hiding this comment.
put this on the line before?
There was a problem hiding this comment.
I think this was trying to test some broken syntax, but I'm fine cleaning it up.
sorvell
reviewed
Apr 6, 2017
test/unit/custom-style-late.html
Outdated
| setTimeout(function() { | ||
| assertComputed(input, '8px'); | ||
| done(); | ||
| }, 125); |
There was a problem hiding this comment.
why the specific timeout here?
There was a problem hiding this comment.
I can use some flush functionality probably.
sorvell
approved these changes
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The included element was never upgrading because it is an extension
element, and CustomStyleInterface boots up async due to
webcomponents/shadycss@33512fc and misses the resync.
This is solved by making a real element.
Also, this test wasn't really "late", so the
<custom-style>isasynchronous now
Fixes #4501