Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom-style-late tests broken in shadycss master #4501

Closed
dfreedm opened this issue Apr 5, 2017 · 0 comments
Closed

custom-style-late tests broken in shadycss master #4501

dfreedm opened this issue Apr 5, 2017 · 0 comments
Assignees
@dfreedm
Labels
2.x p1

Comments

@dfreedm
Copy link
Member

dfreedm commented Apr 5, 2017

Looks like webcomponents/shadycss@33512fc caused the custom-style-late tests to fail.

These tests are weird holdovers from Polymer 1.x and should be rewritten, but the issue may persist after rewriting.
@dfreedm dfreedm self-assigned this Apr 5, 2017
dfreedm added a commit that referenced this issue Apr 6, 2017
@dfreedm
Fix custom-style-late tests
caafef7 
The included element was never upgrading because it is an extension
element, and CustomStyleInterface boots up async due to
webcomponents/shadycss@33512fc and misses the resync.

This is solved by making a real element.

Also, this test wasn't really "late", so the `<custom-style>` is
asynchronous now

Fixes #4501
@dfreedm dfreedm mentioned this issue Apr 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dfreedm dfreedm

Labels
2.x p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dfreedm