Fixes #4357. #4360
Merged
Fixes #4357. #4360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lement. The `importPath` property defaults to the path part of the url containing the dom-module matching the element's static `is` property. The `rootPath` property is set to the `Polymer.rootPath` property and defaults to the path part of the main document url. These properties can be used in bindings to url's. The `importPath` property is used to scope url's in element styles. [Note, this depends on webcomponents/html-imports#44].
kevinpschaaf
requested changes
Mar 2, 2017
lib/mixins/element-mixin.html
Outdated
| * Defaults to the path matching the url containing a `dom-module` element | ||
| * matching this element's static `is` property. | ||
| * Note, this path does not contain a trailing `/`. | ||
| */ |
| @@ -392,13 +392,16 @@ | |||
| * style scoping. | |||
| * @param {HTMLElement} proto | |||
| * @param {HTMLTemplateElement} template | |||
| * @param {string} baseURI URL against which to resolve urls in | |||
| * style element cssText. | |||
There was a problem hiding this comment.
@returns {HTMLTemplateElement}
| } | ||
| super._initializeProperties(); | ||
| // set path defaults | ||
| this.rootPath = Polymer.rootPath; | ||
| this.importPath = importPath; |
There was a problem hiding this comment.
Reminder to discuss why it was bad if these went before initializeProperties
| // support user settings on the Polymer object | ||
| if (userPolymer) { | ||
| Object.assign(Polymer, userPolymer); | ||
| } |
There was a problem hiding this comment.
Just noting, this fixes the ability to set Polymer.sanitizeDOMValue before loading polymer, closing a loophole where it's conceivable that main-document e.g. dom-repeat's could upgrade before the sanitization hook is installed. 👍
lib/utils/resolve-url.html
Outdated
| return (new URL(url, baseURI)).href; | ||
| } | ||
| // Fallback to creating an anchor into a disconnected document. | ||
| let doc = tempDoc; |
|
Also, looks like there's some Linux 41 issue |
* `importPath` can now be a path fragment (e.g. `foo/`)
kevinpschaaf
approved these changes
Mar 3, 2017
added 2 commits
March 2, 2017 18:22
This was referenced Mar 3, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
importPathandrootPathproperties to Polymer.Element. TheimportPathproperty defaults to the path part of the url containing the dom-module matching the element's staticisproperty. TherootPathproperty is set to thePolymer.rootPathproperty and defaults to the path part of the main document url. These properties can be used in bindings to url's. TheimportPathproperty is used to scope url's in element styles. [Note, this depends on this html-imports pr ].