Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4213 #4345

Closed
wants to merge 5 commits into from
Closed

Fixes #4213 #4345

wants to merge 5 commits into from

Conversation

sorvell
Copy link
Contributor

@sorvell sorvell commented Feb 28, 2017

Only rewrite url's in templates that correspond to inline loadable resources (inline style and src attribute). This avoids scoping things like href to template import location which is almost always not what the user wants. When this automated re-writing fails, users should fix url's via binding or imperative code.

…e loadable resources (inline style and src attribute). This avoids scoping things like <a> href to template import location which is almost always not what the user wants. When this automated re-writing fails, users should fix url's via binding or imperative code.
@sorvell
Copy link
Contributor Author

sorvell commented Feb 28, 2017

@sorvell
Copy link
Contributor Author

sorvell commented Feb 28, 2017

Looks good with webcomponents/html-imports#38.

Copy link
Member

@kevinpschaaf kevinpschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sorvell
Copy link
Contributor Author

sorvell commented Mar 1, 2017

Let's hold off on this change for now. We need to figure out how Polymer's hybrid mode works with this before proceeding.

@kevinpschaaf
Copy link
Member

Superseded by #4360

@dfreedm dfreedm deleted the 2.0-rewrite-urls branch September 22, 2017 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants