-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Node.bind to pass the property name to reflectPropertyToAttribute #319
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
<!DOCTYPE html> | ||
<html> | ||
<head> | ||
<title>property to attribute reflection with bind</title> | ||
<script src="../../polymer.js"></script> | ||
<script src="../../../tools/test/htmltest.js"></script> | ||
<script src="../../../tools/test/chai/chai.js"></script> | ||
</head> | ||
|
||
<body> | ||
<polymer-element name="my-child-element"> | ||
<template> | ||
<h1>Hello from the child</h1> | ||
<p>The camelCase is {{camelCase}}, attr is {{attributes.camelCase.value}}</p> | ||
<p>The lowercase is {{lowercase}}, attr is {{attributes.lowercase.value}}</p> | ||
</template> | ||
<script> | ||
Polymer('my-child-element', { | ||
publish: { camelCase: 0, lowercase: 0 }, | ||
// Make this a no-op, so we can verify the initial | ||
// reflectPropertyToAttribute works. | ||
observeAttributeProperty: function(name) { } | ||
}); | ||
</script> | ||
</polymer-element> | ||
|
||
<polymer-element name="my-element"> | ||
<template> | ||
<h1>Hello from the custom element. The volume is {{volume}}</h1> | ||
<p> | ||
<my-child-element id="child" | ||
camelCase="{{volume}}" lowercase="{{volume}}"></my-child-element> | ||
</p> | ||
</template> | ||
<script> | ||
Polymer('my-element', { | ||
publish: { volume: 11 }, | ||
ready: function() { | ||
var child = this.$.child; | ||
chai.assert.equal(child.lowercase, 11); | ||
chai.assert.equal(child.camelCase, 11); | ||
|
||
chai.assert.equal('' + child.lowercase, child.getAttribute('lowercase')); | ||
chai.assert.equal('' + child.camelCase, child.getAttribute('camelcase')); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the test was failing on this line, because camelcase attribute was left as "{{volume}}" |
||
|
||
done(); | ||
} | ||
}); | ||
</script> | ||
</polymer-element> | ||
|
||
<my-element></my-element> | ||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the actual bug fix. figuring out how to reproduce it in the test case was the hard part, because observeAttributeProperty+observe-js polyfills means it doesn't happen in practice for a typical case :)