fix Node.bind to pass the property name to reflectPropertyToAttribute #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty name to it (not attribute name), add test
| chai.assert.equal(child.camelCase, 11); | ||
|
|
||
| chai.assert.equal('' + child.lowercase, child.getAttribute('lowercase')); | ||
| chai.assert.equal('' + child.camelCase, child.getAttribute('camelcase')); |
There was a problem hiding this comment.
the test was failing on this line, because camelcase attribute was left as "{{volume}}"
|
LGTM, thx! |
sorvell
pushed a commit
that referenced
this pull request
Oct 15, 2013
fix Node.bind to pass the property name to reflectPropertyToAttribute
JamesXNelson
pushed a commit
to sdbg/sdbg
that referenced
this pull request
Jan 28, 2014
This is the fix for issue 14060 Polymer.js fix is at: Polymer/polymer#319 [email protected] Review URL: https://codereview.chromium.org//27417002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@28688 260f80e4-7a28-3924-810f-c04153c831b5
svn2github
pushed a commit
to svn2github/dart-lang
that referenced
this pull request
Jul 15, 2014
This is the fix for issue 14060 Polymer.js fix is at: Polymer/polymer#319 [email protected] Review URL: https://codereview.chromium.org//27417002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@28688 260f80e4-7a28-3924-810f-c04153c831b5
jmesserly
pushed a commit
to dart-archive/polymer-dart
that referenced
this pull request
Dec 20, 2014
This is the fix for issue 14060 Polymer.js fix is at: Polymer/polymer#319 [email protected] Review URL: https://codereview.chromium.org//27417002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart/pkg/polymer@28688 260f80e4-7a28-3924-810f-c04153c831b5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...also fixes method name. I think it's supposed to be called "reflectPropertyToAttribute" with an F :)
Apologies for the whitespace changes. My editor is set up to automatically strip trailing whitespace on save, to satisfy the various Google style guides. I can try to revert that if it's a problem.
This was originally reported as https://code.google.com/p/dart/issues/detail?id=14060.