Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Literal args comma fix #1577

Merged
merged 14 commits into from
May 22, 2015
Merged

Literal args comma fix #1577

merged 14 commits into from
May 22, 2015

Commits on May 20, 2015

  1. rename effect.arg to effect.trigger to avoid confusion with `effe… 

    …ct.args`
    @kevinpschaaf
    Scott J Miles authored and kevinpschaaf committed May 20, 2015
    Configuration menu
    Copy the full SHA
    be559b1 View commit details
    Browse the repository at this point in the history

  2. support literal args in _marshalArgs

    @kevinpschaaf
    Scott J Miles authored and kevinpschaaf committed May 20, 2015
    Configuration menu
    Copy the full SHA
    db27411 View commit details
    Browse the repository at this point in the history

  3. require method expressions to use , as argument delimeter, trim whi… 

    …te space from arguments, support literal arguments described as JSON
    @kevinpschaaf
    Scott J Miles authored and kevinpschaaf committed May 20, 2015
    Configuration menu
    Copy the full SHA
    69c472f View commit details
    Browse the repository at this point in the history

  4. basic test for computed expression containing literal args (must also… 

    … contain at least one push dependency at this time)
    @kevinpschaaf
    Scott J Miles authored and kevinpschaaf committed May 20, 2015
    Configuration menu
    Copy the full SHA
    3fd8fbb View commit details
    Browse the repository at this point in the history

  5. rename standard/effects.html to standard/effectBuilder.html

    @kevinpschaaf
    Scott J Miles authored and kevinpschaaf committed May 20, 2015
    Configuration menu
    Copy the full SHA
    89650a1 View commit details
    Browse the repository at this point in the history

  6. * do not treat literal arguments as effect triggers 

    * detect when an annotated computation has only literal arguments, flag it a `static` effect

* when adding a static effect, add it only to the effect list for the __static__ pseudo-property

* expose _executeStaticEffects method to process static effects on demand
    @kevinpschaaf
    Scott J Miles authored and kevinpschaaf committed May 20, 2015
    Configuration menu
    Copy the full SHA
    ab6ce1e View commit details
    Browse the repository at this point in the history

  7. _executeStaticEffects at configure-time

    @kevinpschaaf
    Scott J Miles authored and kevinpschaaf committed May 20, 2015
    Configuration menu
    Copy the full SHA
    6fd5ef8 View commit details
    Browse the repository at this point in the history

  8. rudimentary test for a static effect (annotated computation with only… 

    … literal arguments)
    @kevinpschaaf
    Scott J Miles authored and kevinpschaaf committed May 20, 2015
    Configuration menu
    Copy the full SHA
    0fe9fe7 View commit details
    Browse the repository at this point in the history

  9. * remove bogus support for arbitrary JSON in literal arguments, liter… 

    …al arguments must now be either String or Number

* support using escaped-commas in literal-string arguments: `compute("foo\,bar", zot, 3)`
* support other character escaping which is naturally broken by HTML parser `compute('foo\'bar')`
* test for literal argument _before_ looking for structured args
    @kevinpschaaf
    Scott J Miles authored and kevinpschaaf committed May 20, 2015
    Configuration menu
    Copy the full SHA
    42eaedd View commit details
    Browse the repository at this point in the history

Commits on May 22, 2015

  1. Accept no-arg computed fns as static. Fixes #1516.

    @kevinpschaaf
    kevinpschaaf committed May 22, 2015
    Configuration menu
    Copy the full SHA
    c001344 View commit details
    Browse the repository at this point in the history

  2. Update comment.

    @kevinpschaaf
    kevinpschaaf committed May 22, 2015
    Configuration menu
    Copy the full SHA
    cf5cba7 View commit details
    Browse the repository at this point in the history

  3. Add comment about escaping.

    @kevinpschaaf
    kevinpschaaf committed May 22, 2015
    Configuration menu
    Copy the full SHA
    ffc361c View commit details
    Browse the repository at this point in the history

  4. Move _executeStaticEffects to _applyConfig timing.

    @kevinpschaaf
    kevinpschaaf committed May 22, 2015
    Configuration menu
    Copy the full SHA
    e6859b6 View commit details
    Browse the repository at this point in the history

  5. Add corrected computedFromTrickyLiterals2 test.

    @kevinpschaaf
    kevinpschaaf committed May 22, 2015
    Configuration menu
    Copy the full SHA
    40a9578 View commit details
    Browse the repository at this point in the history