Literal args comma fix #1577
Merged
Literal args comma fix #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
May 20, 2015 15:58
…te space from arguments, support literal arguments described as JSON
… contain at least one push dependency at this time)
* detect when an annotated computation has only literal arguments, flag it a `static` effect * when adding a static effect, add it only to the effect list for the __static__ pseudo-property * expose _executeStaticEffects method to process static effects on demand
… literal arguments)
…al arguments must now be either String or Number
* support using escaped-commas in literal-string arguments: `compute("foo\,bar", zot, 3)`
* support other character escaping which is naturally broken by HTML parser `compute('foo\'bar')`
* test for literal argument _before_ looking for structured args
kevinpschaaf
force-pushed
the
literal-args-comma-fix
branch
from
9e82fe4
to
42eaedd
Compare
|
|
||
| _parseArg: function(rawArg) { | ||
| // clean up whitespace | ||
| var arg = String(rawArg).trim() |
There was a problem hiding this comment.
Seems like rawArg is guaranteed to be a string (comes from split)... seems safe to just do rawArg.trim(). ...
kevinpschaaf
force-pushed
the
literal-args-comma-fix
branch
from
48b329c
to
c001344
Compare
This was referenced May 22, 2015
|
From my tests, I'm still having issues with computed expressions that have only literal arguments. In the example below, node.foobar returns undefined. If I change one of the params to a property, it works just fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.