Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated documentation of dom-repeat #5077

Closed
floribon opened this issue Jan 31, 2018 · 3 comments
Closed

Outdated documentation of dom-repeat #5077

floribon opened this issue Jan 31, 2018 · 3 comments

Comments

@floribon
Copy link
Contributor

floribon commented Jan 31, 2018

Description

The documentation for dom-repeat is using Polymer 1.x syntax. This documentation is present as a JSDoc in the source file and being displayed at webcomponents.org. Happy to create a PR but as this touches public doc the team is probably better placed to review.

Live Demo

https://www.webcomponents.org/element/polymer/polymer/v2.4.0/elements/dom-repeat (or any 2.x.x version)

Expected Results

Usage of <dom-repeat> and Polymer 2 syntax to create a new component with class EmployeeList extends Polymer.Element

Actual Results

Currently displaying <template is="dom-repeat"> and Polymer 1 syntax to create a new component using Polymer({is: 'employee-list'})

Versions

  • Polymer: v2.x

Note that dom-if would benefit of a similar documentation (missing example)

@TimvdLippe
Copy link
Contributor

Hm I am not sure what the policy is for this. @arthurevans @katejeffreys Is the default notation ES6 or Hybrid mode?

@TimvdLippe
Copy link
Contributor

@MajorBreakfast Ah thanks for finding out. @floribon feel free to send a PR to update the documentation 😄

MajorBreakfast added a commit to MajorBreakfast/polymer that referenced this issue Feb 1, 2018
MajorBreakfast added a commit to MajorBreakfast/polymer that referenced this issue Feb 1, 2018
MajorBreakfast added a commit to MajorBreakfast/polymer that referenced this issue Feb 1, 2018
TimvdLippe added a commit that referenced this issue Feb 1, 2018
Use class syntax in <dom-repeat> documentation (#5077)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants