-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outdated documentation of dom-repeat #5077
Comments
Hm I am not sure what the policy is for this. @arthurevans @katejeffreys Is the default notation ES6 or Hybrid mode? |
The official docs consistently use the new style. https://www.polymer-project.org/2.0/docs/devguide/custom-elements |
@MajorBreakfast Ah thanks for finding out. @floribon feel free to send a PR to update the documentation 😄 |
Use class syntax in <dom-repeat> documentation (#5077)
Description
The documentation for dom-repeat is using Polymer 1.x syntax. This documentation is present as a JSDoc in the source file and being displayed at webcomponents.org. Happy to create a PR but as this touches public doc the team is probably better placed to review.
Live Demo
https://www.webcomponents.org/element/polymer/polymer/v2.4.0/elements/dom-repeat (or any 2.x.x version)
Expected Results
Usage of
<dom-repeat>
and Polymer 2 syntax to create a new component withclass EmployeeList extends Polymer.Element
Actual Results
Currently displaying
<template is="dom-repeat">
and Polymer 1 syntax to create a new component usingPolymer({is: 'employee-list'})
Versions
Note that dom-if would benefit of a similar documentation (missing example)
The text was updated successfully, but these errors were encountered: