Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use class syntax in <dom-repeat> documentation (#5077) #5083

Merged
merged 1 commit into from
Feb 1, 2018
Merged

Use class syntax in <dom-repeat> documentation (#5077) #5083

merged 1 commit into from
Feb 1, 2018

Conversation

MajorBreakfast
Copy link
Contributor

Fixes #5077

TimvdLippe
TimvdLippe approved these changes Feb 1, 2018
View reviewed changes
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @MajorBreakfast for the quick PR!

@TimvdLippe
Copy link
Contributor

Oh please run gulp update-types to update our own types, as we changed the documentation

@TimvdLippe
Copy link
Contributor

Awesome, thanks again!

@TimvdLippe TimvdLippe merged commit 86399df into Polymer:master Feb 1, 2018
@MajorBreakfast
Copy link
Contributor Author

BTW I'll be so happy once the JavaScript class fields proposal lands. The static get properties () { return ...; } nonsense is atrocious. xD

@floribon floribon mentioned this pull request Feb 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimvdLippe TimvdLippe TimvdLippe approved these changes

@dfreedm dfreedm Awaiting requested review from dfreedm

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

@sorvell sorvell Awaiting requested review from sorvell

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MajorBreakfast @TimvdLippe @googlebot