Merge pull request #5650 from Polymer/attribute-override-types

Fix TypeScript breakages by specifying types for overridden `setAttribute` and `getAttribute`.
Polymer · Apr 28, 2020 · f73c89b · f73c89b
2 parents 282bd34 + 370ae5e
commit f73c89b
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/lib/legacy/legacy-element-mixin.js b/lib/legacy/legacy-element-mixin.js
@@ -143,7 +143,12 @@ export const LegacyElementMixin = dedupingMixin((base) => {
       }
     }
 
-    /** @override */
+    /**
+     * Sets the value of an attribute.
+     * @override
+     * @param {string} name The name of the attribute to change.
+     * @param {string} value The new attribute value.
+     */
     setAttribute(name, value) {
       if (legacyNoObservedAttributes && !this._legacyForceObservedAttributes) {
         const oldValue = this.getAttribute(name);
@@ -155,7 +160,11 @@ export const LegacyElementMixin = dedupingMixin((base) => {
       }
     }
 
-    /** @override */
+    /**
+     * Removes an attribute.
+     * @override
+     * @param {string} name The name of the attribute to remove.
+     */
     removeAttribute(name) {
       if (legacyNoObservedAttributes && !this._legacyForceObservedAttributes) {
         const oldValue = this.getAttribute(name);