Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeScript breakages by specifying types for overridden setAttribute and getAttribute. #5650

Merged
merged 2 commits into from
Apr 28, 2020
Merged

Fix TypeScript breakages by specifying types for overridden setAttribute and getAttribute. #5650

merged 2 commits into from
Apr 28, 2020

Conversation

bicknellr
Copy link
Member

No description provided.

@bicknellr bicknellr marked this pull request as ready for review April 28, 2020 01:47
@bicknellr bicknellr merged commit f73c89b into master Apr 28, 2020
@bicknellr bicknellr deleted the attribute-override-types branch April 28, 2020 03:37
@robrez robrez mentioned this pull request Apr 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aomarks aomarks aomarks approved these changes

@dfreedm dfreedm Awaiting requested review from dfreedm

@sorvell sorvell Awaiting requested review from sorvell

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bicknellr @aomarks @googlebot