Make event notification handler read the value from currentTarget,

instead of target which may not be bound to any data. Fixes #5308
Polymer · Jul 30, 2018 · f1600f3 · f1600f3
1 parent d59546d
commit f1600f3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/mixins/property-effects.html b/lib/mixins/property-effects.html
@@ -356,7 +356,7 @@
       toPath = Polymer.Path.translate(fromProp, toPath, fromPath);
       value = detail && detail.value;
     } else {
-      value = event.target[fromProp];
+      value = event.currentTarget[fromProp];
     }
     value = negate ? !value : value;
     if (!inst[TYPES.READ_ONLY] || !inst[TYPES.READ_ONLY][toPath]) {

diff --git a/test/unit/property-effects.html b/test/unit/property-effects.html
@@ -329,6 +329,18 @@
     assert.equal(el.observerCounts.customEventValueChanged, 1, 'custom bound property observer not called');
   });
 
+  test('custom notification bubbling event to property', function() {
+    const child = document.createElement('div');
+    el.$.boundChild.appendChild(child);
+
+    el.$.boundChild.customEventValue = 42;
+    child.dispatchEvent(new Event('custom', {bubbles: true}));
+    console.warn(el.$.boundChild.customEventValue);
+    console.warn(el.$.boundChild.customEventValue);
+    assert.equal(el.customEventValue, 42, 'custom bound property incorrect');
+    assert.equal(el.observerCounts.customEventValueChanged, 1, 'custom bound property observer not called');
+  });
+
   test('custom notification event to path', function() {
     el.clearObserverCounts();
     el.$.boundChild.customEventObjectValue = 84;