Date binding notification events are broken if the bound element has children

[tomalec]

Description

Notification events do not work if the bound element has children. They seem to read the value from the descendant node instead of the bound one.

<div onclick="++this.value" value="{{value::click}}">
  works
  <b>fails</b>
</div>

Live Demo

https://glitch.com/edit/#!/small-duke?path=index.html:13:41

Steps to Reproduce

1. Create div with property bound with notification event, like value="{{value::click}}"
2. Append an element to the div
3. Click (or trigger a bubbling event) on div

Expected Results

The property (value) should be changed.

Actual Results

The property is set to undefined or any value of descendant.property.

Browsers Affected

• Chrome
• Firefox
• Edge
• [?] Safari 11
• [?] Safari 10
• IE 11

Versions

• Polymer: v2.6.0
• webcomponents: v1.2.3

Possible fix

Seems that handleNotification should check event.currentTarget not event.target at

polymer/lib/mixins/property-effects.js

Line 356 in 5807ce0

value = event.target[fromProp];

[TimvdLippe]

@tomalec Seems like a valid case. Do you mind filing a PR with the fix + test cases? Please submit them to both the 2.x and the 3.x branch. Thanks! 😄

[tomalec]

@TimvdLippe Here you have 2.x #5309 :)

[tomalec]

@jsilvermist That's the point I use native onclick to trigger event listener given in {{prop::event}} syntax

[TimvdLippe]

@tomalec Awesome thanks. Once that is merged, please also open a PR on master for 3.x

[tomalec]

Thanks a lot for the quick feedback :)

[TimvdLippe]

Likewise for the detailed issue + solution PR :) Op do 2 aug. 2018 om 15:31 schreef Tomek Wytrębowicz < [email protected]>:

…

Thanks a lot for the quick feedback :) — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#5308 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFrDb29S05VeTS3l8fsdr9rUecgowQcAks5uMv8xgaJpZM4VmUbC> .