This repository has been archived by the owner on Sep 24, 2021. It is now read-only.
Add unbalanced polymer databinding delimitors rule. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rictic
force-pushed
the
unbalanced-delimitors
branch
from
5cd2dd9 to
64abc4b
Compare
|
Fixes #30 |
usergenic
suggested changes
Feb 23, 2017
src/polymer/matchers.ts
Outdated
|
|
||
| export interface Template extends parse5.ASTNode { content: parse5.ASTNode; } | ||
|
|
||
| export function getNestedDataBindingTemplates(node: parse5.ASTNode) { |
There was a problem hiding this comment.
I feel like this needs commenting. Also, I feel like matchers.ts should be all predicate functions, but maybe that wouldn't make sense for this one, so not a deal-breaker.
There was a problem hiding this comment.
It turns out that this can be written more correctly as a predicate (as top level dom-if and dom-repeat is allowed).
rictic
force-pushed
the
unbalanced-delimitors
branch
from
32dc95c to
40ef567
Compare
rictic
force-pushed
the
unbalanced-delimitors
branch
from
fc6ae8e to
0bc3850
Compare
Add typings for parse5 Fix spelling of delimiters. Allow toplevel dom-if and dom-repeat.
* Add two known failures in expression parsing to integration tests. * Warn when binding to undeclared attributes and properties. * Add test, suggest nearest spelling when no attribute found. * Fix the warning for data-* attributes. * Add issue for TODO * Update CHANGELOG, improve documentation * Remove TODO for implemented feature. * Update integration test with new rule code. * Use consistent naming, also check attributes outside polymer databindings. * Update integration tests
rictic
force-pushed
the
unbalanced-delimitors
branch
from
0bc3850 to
141af21
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steals from @usergenic's PR #1
This change is