This repository has been archived by the owner on Sep 24, 2021. It is now read-only.
Add a warning for databinding to undeclared properties/attributes #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rictic
force-pushed
the
bind-to-undeclared
branch
2 times, most recently
from
f6ce6fd to
f1496f3
Compare
usergenic
reviewed
Feb 23, 2017
src/polymer/bind-to-undeclared.ts
Outdated
| const propertyOptions = element.properties.map((a) => a.name) | ||
| .concat(Array.from(sharedProperties.keys())); | ||
| const closestAttribute = | ||
| minBy(attributeOptions, (option) => levenshtein.get(name, option)); |
usergenic
reviewed
Feb 23, 2017
CHANGELOG.md
Outdated
| element. | ||
|
|
||
| This catches misspellings, forgetting to convert camelCase to kebab-case, | ||
| and binding to attributes like class and style like they were properties.Warns when setting an unknown attribute or property on a custom element in a polymer databinding template. Catches misspellings |
usergenic
reviewed
Feb 23, 2017
src/polymer/bind-to-undeclared.ts
Outdated
|
|
||
|
|
||
| export class BindToUndeclaredAttributes extends HtmlRule { | ||
| code = 'unknown-set-attribute'; |
There was a problem hiding this comment.
Why is this code so different from the rule class name?
rictic
force-pushed
the
bind-to-undeclared
branch
from
bd8587f to
abefc4b
Compare
rictic
force-pushed
the
unbalanced-delimitors
branch
from
32dc95c to
40ef567
Compare
rictic
force-pushed
the
bind-to-undeclared
branch
from
abefc4b to
609bcdd
Compare
|
Comments addressed. Also now understands and correctly lints setting attributes outside a polymer databinding context too. |
rictic
added a commit
that referenced
this pull request
Feb 25, 2017
* Add two known failures in expression parsing to integration tests. * Warn when binding to undeclared attributes and properties. * Add test, suggest nearest spelling when no attribute found. * Fix the warning for data-* attributes. * Add issue for TODO * Update CHANGELOG, improve documentation * Remove TODO for implemented feature. * Update integration test with new rule code. * Use consistent naming, also check attributes outside polymer databindings. * Update integration tests
rictic
added a commit
that referenced
this pull request
Feb 25, 2017
* Add two known failures in expression parsing to integration tests. * Warn when binding to undeclared attributes and properties. * Add test, suggest nearest spelling when no attribute found. * Fix the warning for data-* attributes. * Add issue for TODO * Update CHANGELOG, improve documentation * Remove TODO for implemented feature. * Update integration test with new rule code. * Use consistent naming, also check attributes outside polymer databindings. * Update integration tests
rictic
added a commit
that referenced
this pull request
Feb 25, 2017
* Add two known failures in expression parsing to integration tests. * Warn when binding to undeclared attributes and properties. * Add test, suggest nearest spelling when no attribute found. * Fix the warning for data-* attributes. * Add issue for TODO * Update CHANGELOG, improve documentation * Remove TODO for implemented feature. * Update integration test with new rule code. * Use consistent naming, also check attributes outside polymer databindings. * Update integration tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25
This change is