Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Document observe block #173

Closed
sorvell opened this issue Oct 17, 2013 · 3 comments
Closed

Document observe block #173

sorvell opened this issue Oct 17, 2013 · 3 comments
Assignees

Comments

@sorvell
Copy link

sorvell commented Oct 17, 2013

Added here: Polymer/polymer@3a749f8

@ghost ghost assigned ebidel Oct 17, 2013
@ebidel
Copy link
Contributor

ebidel commented Oct 19, 2013

There's a lot going on in this CL. The important part is the observe block
to define path observation in an object? As used here:

https://github.com/Polymer/polymer/blob/3a749f848ee6374fe57822b1923ad40b572648b8/test/html/property-observe.html#L19:L23

Is it also worth documenting Path.get() (and anything else Path
provides)?

On Thu, Oct 17, 2013 at 4:25 PM, Steve Orvell [email protected]:

Added here: Polymer/polymer@3a749f8Polymer/polymer@3a749f8


Reply to this email directly or view it on GitHubhttps://github.com//issues/173
.

@ebidel ebidel closed this as completed in b4c19c2 Oct 28, 2013
@ebidel
Copy link
Contributor

ebidel commented Oct 28, 2013

@sorvell please look this over. There's a third param passed to the custom observer callback (an array of arrays)? What is that?

@sorvell
Copy link
Author

sorvell commented Oct 28, 2013

When multiple properties result in 1 observer firing, the arguments are incorrect (Polymer/polymer#321). The last argument is a stopgap. It's the list of all change info, and it can be iterated through to discover the missing old values. We probably shouldn't doc this since it's going to be improved shortly.

Otherwise, looks good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants