-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When multiple property changes provoke a single change method, arguments to that method are incorrect #321
Comments
For example:
|
@rafaelw We are currently using a single CompoundPathObserver (cpo) to watch properties. For the case shown above, it seems like we want a separate cpo to track this set of changes. Otherwise, the master cpo has to do significant work to pass along the right set of changes, work that cpo exists to do. wdyt? @frankiefu was concerned that the cpo api (changeHandler(newValues, oldValues, changes, paths) ) is too cumbersome and that we want to sugar it somewhat. He wanted something like changeHandler(changes) where changes would be an object with changes[path].oldValue, changes[path].newValue, changes[path].changed. |
I think the task here is to define what the callback API should do. I seriously doubt the solution requires more than one CompoundObserver |
Closing this issue due to age and the release of version 1 of Polymer - please feel free to re-open if this is incorrect. |
Now that multiple property changes can provoke a single property change method call, the arguments to the property change method must include all the old and new values and probably also the names of the properties that have changed.
The text was updated successfully, but these errors were encountered: