[pcl_io] Set libusb as a required dependency of openni in non-Windows#5028
Merged
larshg merged 1 commit intoPointCloudLibrary:masterfrom Nov 18, 2021
Conversation
Contributor
Author
|
@mvieth Can you please review this PR? |
mvieth
approved these changes
Nov 16, 2021
Member
mvieth
left a comment
mvieth
left a comment
There was a problem hiding this comment.
I thought about alternative fixes, like requiring libusb specifically for the failing target pcl_ground_based_rgbd_people_detector, but requiring it always when OpenNI is desired for all non-Windows systems seems reasonable to me. Thanks!
larshg
approved these changes
Nov 16, 2021
JackBoosY
deleted the
dev/jack/add-libusb-dependency-with-openni-non-win
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the condition of finding
libusbinFindOpenNI[2].cmaketo adapt to the condition in cpp code.Fixes #5027.