Skip to content

fix: restrict api call loop#1627

Closed
sunilsabatp wants to merge 1 commit into
developfrom
Fix/api_call_loop
Closed

fix: restrict api call loop#1627
sunilsabatp wants to merge 1 commit into
developfrom
Fix/api_call_loop

Conversation

@sunilsabatp
Copy link
Copy Markdown
Contributor

@sunilsabatp sunilsabatp commented Dec 1, 2022 •
edited
Loading

visit to -> /yucatan?ploc=RM0TJZand change locale to DE
issue -> api call loop (see the network tab once a specific plant location get selected)
get more insight ->#1618 (comment)
also visit the comment to get demo of the issue ->#1618 (comment)

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
planet-webapp ✅ Ready (Inspect) Visit Preview Dec 1, 2022 at 3:52AM (UTC)

@sagararyal
Copy link
Copy Markdown
Member

sagararyal commented Dec 1, 2022

📝 Changed routes:

/[p] /
Screenshot of /[p]
(view full size)		 Screenshot of /
(view full size)

Commit f4e38d0 (https://planet-webapp-3obn5vh3e-planetapp.vercel.app).

@sunilsabatp sunilsabatp requested a review from mohitb35 December 1, 2022 03:58
@norbertschuler
Copy link
Copy Markdown
Collaborator

norbertschuler commented Dec 3, 2022 •
edited
Loading

@sunilsabatp can we merge this into #1618 - base this PR on Fix/ZoomIN_to_SinglePlantLocation to merge it into this PR and test it there?

@sunilsabatp
Copy link
Copy Markdown
Contributor Author

sunilsabatp commented Dec 5, 2022

@sunilsabatp can we merge this into #1618 - base this PR on Fix/ZoomIN_to_SinglePlantLocation to merge it into this PR and test it there?

we can merge it .but, since this issue is not specific to this pr Fix/ZoomIN_to_SinglePlantLocation , therefore, we should test it separately

norbertschuler
norbertschuler previously approved these changes Dec 18, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@norbertschuler norbertschuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not wanting to merge this directly into #1618, let's merge it into develop and then merge develop into #1618.

mohitb35
mohitb35 requested changes Jan 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@mohitb35 mohitb35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunilsabatp The language switching on the project details (/p]) page does not update the project language any more.

@mohitb35 mohitb35 assigned mohitb35 and sarveshpro and unassigned mohitb35 Jan 23, 2023
@mariahosfeld
Copy link
Copy Markdown
Contributor

mariahosfeld commented Apr 25, 2023

Tested functionality, without a manual refresh the language does no longer change in the descriptions.

@mariahosfeld
Copy link
Copy Markdown
Contributor

mariahosfeld commented Nov 22, 2023

No longer needed, therefore closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mohitb35 mohitb35 mohitb35 requested changes

@norbertschuler norbertschuler norbertschuler left review comments

Assignees

@sarveshpro sarveshpro

Labels

PR: reviewed-changes-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sunilsabatp @sagararyal @norbertschuler @mariahosfeld @mohitb35 @sarveshpro