samplePlantLocation Bug#1618
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Functionality works for me. |
mohitb35
requested changes
Nov 23, 2022
| key={`${spl.id}-marker`} | ||
| className={`${styles.single} ${ | ||
| spl.id === selectedPl?.id | ||
| spl.hid === selectedPl?.hid |
Member
There was a problem hiding this comment.
@sunilsabatp Why do we compare hid instead of id here?
Collaborator
20221126_test.mp4 |
Member
|
mohitb35
reviewed
Nov 28, 2022
Member
mohitb35
left a comment
mohitb35
left a comment
There was a problem hiding this comment.
The code looks mostly good to me, it resolves the specific issues of
- Crash on clicking on a sample tree - now the sample tree details persist after click.
- Clicking on the present plant location (outlined plant location) no longer zooms the user out of the map - it only shows the correct info in the project snippet.
I've left some minor comments. Once those are done, this should be good to merge.
Note: #1618 (comment) should be resolved separately. It does not seem to be linked to the fixes here.
This reverts commit 96e48e4.
mohitb35
approved these changes
Jan 13, 2023
Member
|
@mariahosfeld This is approved. It can be released along with the next 12 update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue-> visit
https://planet-webapp-kb4pti3b8-planetapp.vercel.app/yucatan?ploc=QYVMCIand select one of the sample plant within that plantLocation