Skip to content

Feature/new route redeem code#1568

Merged
mariahosfeld merged 13 commits into
developfrom
feature/new_route_redeem_code
Oct 12, 2022
Merged

Feature/new route redeem code#1568
mariahosfeld merged 13 commits into
developfrom
feature/new_route_redeem_code

Conversation

@sunilsabatp

Copy link
Copy Markdown
Contributor

to do -> create a new route to handle redeem

steps:
1.use the route /profile/redeem/:code to see the result

@vercel

vercel Bot commented Sep 16, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
planet-webapp ✅ Ready (Inspect) Visit Preview Oct 10, 2022 at 6:25AM (UTC)

@sagararyal

sagararyal commented Sep 16, 2022

Copy link
Copy Markdown
Member

@mariahosfeld mariahosfeld left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Route works, but the following changes are needed:

  • Make sure that new tree count is shown automatically, currently a refresh is needed
  • Provide option to redeem another code in each modal (successfully, already redeemed, invalid)

@sunilsabatp

sunilsabatp commented Sep 20, 2022

Copy link
Copy Markdown
Contributor Author

Route works, but the following changes are needed:

  • Make sure that new tree count is shown automatically, currently a refresh is needed
  • Provide option to redeem another code in each modal (successfully, already redeemed, invalid)

the first issue have already been fixed by one of my pr i.e redeem end point

@mariahosfeld

mariahosfeld commented Sep 23, 2022

Copy link
Copy Markdown
Contributor

Functionality of redeeming one code works for me.
When I choose "redeem another code" and enter the same code, I do not get a is already redeemed feedback, nothing really happens

@mariahosfeld

Copy link
Copy Markdown
Contributor

Functionality works for me, when I enter an invalid local it automatically shows me everything in my browser language.

@norbertschuler

Copy link
Copy Markdown
Collaborator

If this PR replaces #1554 (which I then just unnecessarily tested :-() please close the outdated PR.

@mohitb35

Copy link
Copy Markdown
Member

If this PR replaces #1554 (which I then just unnecessarily tested :-() please close the outdated PR.

@norbertschuler This PR is in addition to #1554 - #1554 updates the redemption process from the profile via the RedeemModal, and this PR focuses on a route to directly redeem a code.

@norbertschuler

Copy link
Copy Markdown
Collaborator

I would prefer upgrading package-lock.json only in the PR has changed package.json or do upgrades in separate PR's which then check if all modules still work well.

@norbertschuler

norbertschuler commented Oct 3, 2022

Copy link
Copy Markdown
Collaborator

Bildschirmfoto 2022-10-03 um 12 15 11

}
}
}, [router]);
}, [router, router.query.type, ready]);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need router and router.query.type both as dependencies here?

@mariahosfeld

Copy link
Copy Markdown
Contributor
Bildschirmfoto 2022-10-03 um 12 15 11

This has been solved, will now result in "invalid code" message.

@mariahosfeld mariahosfeld merged commit cfa5c30 into develop Oct 12, 2022
@mariahosfeld mariahosfeld deleted the feature/new_route_redeem_code branch October 12, 2022 07:21
This was referenced Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants