Feature/redeem endpoint#1554
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 Changed routes:
Commit a2a8aac (https://planet-webapp-qch9zjbzb-planetapp.vercel.app). |
![Screenshot of /claim/[type]/[code]](https://images.weserv.nl?url=https://sjc.microlink.io/3GpuNCdVUYVu9Z8CcobsYTJq8IOnCRhYYgQjt3BD7RQIGHNBPuGJUISapcGZtbkYnGBRt_Pfyr2-agzeKnQq5w.png&w=600)
|
Receiving "Clientside-exception" error message after logging in. |
|
Function works for me, please change the following thing:
|
|
Functionality works for me |
This comment was marked as resolved.
This comment was marked as resolved.
| @@ -103,7 +101,7 @@ export default function RedeemModal({ | |||
| async function redeemCode() { | |||
There was a problem hiding this comment.
This is not used any more, and can be removed.
There was a problem hiding this comment.
Please remove this completely, don't leave it commented. If you need to go back to check it out, version control holds the history of the file.
| <div className={styles.codeTreeCount}> | ||
| <div | ||
| className={styles.codeTreeCount} | ||
| style={{ fontSize: '2rem' }} |
There was a problem hiding this comment.
Avoid using inline styles (esp. if there's already a class defined).
|
The layout is not consistent across the 3 different states of the modal: input form, invalid/used code, success.
|
- remove unused state variables and console logs - remove extra line spacing - add return type for functional component
mohitb35
left a comment
mohitb35
left a comment
There was a problem hiding this comment.
@sunilsabatp Have requested minor changes. Once done, this is good to go.
|
Looks good to me. |
| }); | ||
| } | ||
| } | ||
| // async function redeemCode(code: any, type: any) { |
There was a problem hiding this comment.
I think we can remove unused code. We have git if we want to retrieve it again.
5 participants
to do : change reedem end-point
previous endpoint : https://app-staging.plant-for-the-planet.org/api/v1.3/de/validateCode
change to : https://app.plant-for-the-planet.org/app/redeem
steps : 1. go to /profile
2. click on redeem and enter redeem code
3. click on validate code