feat(connect-react): prep preview of @pipedream/connect-react #14718
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,7 +51,7 @@ jobs: | |
| uses: actions/[email protected] | ||
| - uses: pnpm/[email protected] | ||
| with: | ||
| version: 9.14.2 | ||
| - name: Get pnpm store directory | ||
| id: pnpm-cache | ||
| run: | | ||
|
|
@@ -140,7 +140,7 @@ jobs: | |
| uses: actions/[email protected] | ||
| - uses: pnpm/[email protected] | ||
| with: | ||
| version: 9.14.2 | ||
| - name: Get pnpm store directory | ||
| id: pnpm-cache | ||
| run: | | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -18,15 +18,30 @@ jobs: | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| - name: Checkout code | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| uses: actions/checkout@v4 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| - uses: pnpm/[email protected] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| with: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| version: 9.14.2 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| - name: Get pnpm store directory | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| id: pnpm-cache | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| run: | | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| echo "::set-output name=pnpm_cache_dir::$(pnpm store path)" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| - uses: actions/cache@v4 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| name: Setup pnpm cache | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| with: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }} | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }} | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| restore-keys: | | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| ${{ runner.os }}-pnpm-store- | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| - name: Set up Node.js | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| uses: actions/setup-node@v3 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| with: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| node-version: '18' | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| - name: Install dependencies | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| run: pnpm install | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| working-directory: packages/sdk | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| - name: Run tests | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| run: pnpm test | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+42
to
+46
There was a problem hiding this comment. Add proper pnpm setup steps before using pnpm commands While switching to pnpm is good for consistency, the workflow needs additional setup steps to ensure reliable execution. Add these steps before the "Install dependencies" step: - name: Set up Node.js
uses: actions/setup-node@v3
with:
node-version: '18'
+ - name: Install pnpm
+ uses: pnpm/action-setup@v2
+ with:
+ version: 9.14.2
+
+ - name: Setup pnpm cache
+ uses: actions/cache@v3
+ with:
+ path: ~/.pnpm-store
+ key: ${{ runner.os }}-pnpm-${{ hashFiles('**/pnpm-lock.yaml') }}
+ restore-keys: |
+ ${{ runner.os }}-pnpm-
- name: Install dependencies
run: pnpm install
working-directory: packages/sdkThis ensures:
📝 Committable suggestion
Suggested change
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| working-directory: packages/sdk | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ jobs: | |
| uses: actions/[email protected] | ||
| - uses: pnpm/[email protected] | ||
| with: | ||
| version: 9.14.2 | ||
|
There was a problem hiding this comment. Verify Node.js compatibility with pnpm 9.14.2 The workflow uses Node.js 14 with pnpm 9.14.2. According to pnpm's documentation, version 9.x requires Node.js 16 or higher. Consider upgrading the Node.js version to ensure compatibility. Apply this change to both jobs: uses: actions/[email protected]
with:
- node-version: 14
+ node-version: 16Also applies to: 125-125 |
||
| - name: Get pnpm store directory | ||
| id: pnpm-cache | ||
| run: | | ||
|
|
@@ -122,7 +122,7 @@ jobs: | |
| uses: actions/[email protected] | ||
| - uses: pnpm/[email protected] | ||
| with: | ||
| version: 9.14.2 | ||
| - name: Get pnpm store directory | ||
| id: pnpm-cache | ||
| run: | | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ jobs: | |
| uses: actions/[email protected] | ||
| - uses: pnpm/[email protected] | ||
| with: | ||
| version: 9.14.2 | ||
|
There was a problem hiding this comment. Verify Node.js compatibility with pnpm 9.14.2 The workflow uses Node.js 14 which might be too old for pnpm 9.x. According to pnpm's documentation, version 9.x requires Node.js 16 or higher. Consider updating the Node.js version in the workflow: uses: actions/[email protected]
with:
- node-version: 14
+ node-version: 16
|
||
| - name: Get pnpm store directory | ||
| id: pnpm-cache | ||
| run: | | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,7 +23,7 @@ jobs: | |
| - uses: actions/[email protected] | ||
| - uses: pnpm/[email protected] | ||
| with: | ||
| version: 9.14.2 | ||
| - name: Get pnpm store directory | ||
| if: github.ref != 'refs/heads/master' # Cache is used only for dry runs | ||
| id: pnpm-cache | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,7 +15,7 @@ jobs: | |
| - uses: actions/[email protected] | ||
| - uses: pnpm/[email protected] | ||
| with: | ||
| version: 9.14.2 | ||
| - uses: actions/[email protected] | ||
| with: | ||
| node-version: 18 | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,7 +55,7 @@ jobs: | |
| fetch-depth: 0 | ||
| - uses: pnpm/[email protected] | ||
| with: | ||
| version: 9.14.2 | ||
| - name: Get pnpm store directory | ||
| id: pnpm-cache | ||
| run: | | ||
|
|
@@ -70,31 +70,29 @@ jobs: | |
| - name: Install dependencies | ||
| run: pnpm install -r | ||
| - name: Setup Node Env | ||
| uses: actions/setup-node@v4.1.0 | ||
| with: | ||
| node-version: 18.18.0 | ||
| registry-url: https://registry.npmjs.org/ | ||
| cache: 'pnpm' | ||
| # - name: Lint Code Base | ||
| # uses: super-linter/super-linter/[email protected] | ||
| # env: | ||
| # DEFAULT_BRANCH: master | ||
| # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| # JAVASCRIPT_ES_CONFIG_FILE: eslint.config.mjs | ||
| # LINTER_RULES_PATH: / | ||
| # VALIDATE_ALL_CODEBASE: false | ||
| # VALIDATE_JAVASCRIPT_ES: true | ||
| # VALIDATE_JSON: true | ||
| # ESLint only on changed files (not the same as the above super-linter) | ||
| - name: Get Changed Files (space-separated) | ||
| id: changed_files_space | ||
| uses: Ana06/[email protected] | ||
| with: | ||
| format: 'space-delimited' | ||
| - name: Lint changed files | ||
| run: pnpm exec eslint ${{ steps.changed_files_space.outputs.added_modified }} ${{ steps.changed_files_space.outputs.renamed }} | ||
| - name: Get Changed Files (comma-separated) | ||
| id: changed_files | ||
| uses: Ana06/[email protected] | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Update deprecated workflow command and optimize cache configuration
set-outputcommand is deprecated. Use the newGITHUB_OUTPUTsyntax instead.Apply this diff:
- name: Get pnpm store directory id: pnpm-cache run: | - echo "::set-output name=pnpm_cache_dir::$(pnpm store path)" + echo "pnpm_cache_dir=$(pnpm store path)" >> $GITHUB_OUTPUT - uses: actions/cache@v4 name: Setup pnpm cache with: path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }} - key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }} + key: ${{ runner.os }}-pnpm-store-${{ matrix.node-version }}-${{ hashFiles('**/pnpm-lock.yaml') }} restore-keys: | - ${{ runner.os }}-pnpm-store- + ${{ runner.os }}-pnpm-store-${{ matrix.node-version }}- + ${{ runner.os }}-pnpm-store-🧰 Tools
🪛 actionlint (1.7.3)
26-26: workflow command "set-output" was deprecated. use
echo "{name}={value}" >> $GITHUB_OUTPUTinstead: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions(deprecated-commands)