Fix deprecated realtime_tools header imports #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjahr
approved these changes
Feb 5, 2025
|
Thanks! |
sjahr
reviewed
Feb 5, 2025
...t_fault_controller/include/picknik_reset_fault_controller/picknik_reset_fault_controller.hpp
Show resolved
Hide resolved
picknik_twist_controller/include/picknik_twist_controller/picknik_twist_controller.hpp
Show resolved
Hide resolved
|
The .hpp files already exist on Humble/Jazzy, it was just failing the ABI stability check. Particularly for Rolling, this repo failed on the buildfarm specifically because of ABI breakages we are trying to address. IMO put it back how it was, since we know it actually works on all supported distros with .hpp files, and just merge through the failures. Also, there is a separate issue of this CI still using Iron instead of Jazzy, but unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These packages got knocked out of the latest Rolling sync due to deprecated headers, which in turn also knocked out some of the Kinova packages that rely on these controllers.
Please approve and cut a patch release!