Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #31 and doesn't require users to change their usage really at all, just adds 0 as a sentinel value.
Also takes care of this issue I saw in pre-commit:
My question regarding this change is: should we have the default reset time be 0? As mentioned in #31, I can understand wanting a different default behavior. I also understand not wanting to fill the disk super quickly though, especially since there's no way to ensure a user sees a warning in the docstring. I am open to other suggestions on this, but thought I'd make this PR just to start discussion.
Some other possibilities I considered:
RestartRecording
- Questionable default behavior #31). Though this is easy to do, I opted to make the PR as-is since it is the smallest code change.reset_time
data saved. Perhaps a more forgiving default behavior, but maybe a little odd