Automatically RestartRecording - Questionable default behavior

[adv4ncr]

Hi Davide,
Thank you for creating such a great capture tool. We use it extensively in our research.
While recording a long dataset, I noticed the somewhat questionable default behavior of data_tamer to clear and restart the current measurement after 10 minutes:

data_tamer/data_tamer_cpp/src/sinks/mcap_sink.cpp

Lines 121 to 124 in 5750ccf

	if(now - start_time_ > reset_time_)
	{
	restartRecording(filepath_, compression_);
	}

I have increased the reset time with setMaxTimeBeforeReset(), but the default behavior may not be obvious to many people, especially since the existing measurement file is overwritten without notice.
In my opinion it would be better not to automatically restart the measurement or to automatically create a new file with a counter appended to the filename.

What do you think?

Yours
Vinc

[henrygerardmoore]

I made #32 to allow for unlimited recording, please feel welcome to add a comment there on your preferred usage! There are a couple different options, and I'd be happy to implement any of them depending on your and @facontidavide's preferences.

[facontidavide]

I agree that default should change.
Creating a new file should also be an option

[henrygerardmoore]

That seems like a good idea. I'll merge #32 as-is and make a separate PR to allow for creating new files, too.