Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min_coverage parameter to threshold parcel coverage #782

Merged
merged 7 commits into from
Feb 7, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Jan 31, 2023

Closes #776.

Changes proposed in this pull request

  • Add min_coverage parameter to the CLI, along with each of the workflows and interfaces that need it.

Documentation that should be reviewed

None.

@tsalo tsalo added the enhancement New feature or request label Jan 31, 2023
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Base: 70.31% // Head: 70.69% // Increases project coverage by +0.38% 🎉

Coverage data is based on head (2bce09d) compared to base (39f949e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #782      +/-   ##
==========================================
+ Coverage   70.31%   70.69%   +0.38%     
==========================================
  Files          71       72       +1     
  Lines        6465     6505      +40     
==========================================
+ Hits         4546     4599      +53     
+ Misses       1919     1906      -13     
Impacted Files Coverage Δ
xcp_d/tests/test_cli.py 100.00% <ø> (ø)
xcp_d/workflows/base.py 97.82% <ø> (ø)
xcp_d/workflows/bold.py 93.98% <ø> (ø)
xcp_d/workflows/cifti.py 94.48% <ø> (ø)
xcp_d/cli/parser_utils.py 92.06% <100.00%> (+24.79%) ⬆️
xcp_d/cli/run.py 51.04% <100.00%> (+0.17%) ⬆️
xcp_d/interfaces/connectivity.py 100.00% <100.00%> (ø)
xcp_d/interfaces/prepostcleaning.py 95.79% <100.00%> (-0.06%) ⬇️
xcp_d/tests/test_cli_utils.py 100.00% <100.00%> (ø)
xcp_d/tests/test_workflows_connectivity.py 95.45% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

tsalo added a commit to tsalo/xcp_d that referenced this pull request Feb 3, 2023
Should play nicely with PennLINC#782.
@tsalo tsalo merged commit 2d2ed9f into PennLINC:main Feb 7, 2023
@tsalo tsalo deleted the coverage-threshold-parameter branch February 7, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make coverage threshold configurable
1 participant