Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修改COPY-FROM No. 2 jit #5983

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Jun 27, 2023

修改COPY-FROM No. 2 jit

PADDLEPADDLE_PR=54920

@paddle-bot
Copy link

paddle-bot bot commented Jun 27, 2023

感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-5983.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明,请参考:飞桨文档预览工具

@gouzil
Copy link
Member Author

gouzil commented Jun 27, 2023

@sunzhongkai588

@gouzil
Copy link
Member Author

gouzil commented Jun 29, 2023

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 30, 2023
prog_trans = paddle.jit.ProgramTranslator()
static_func = prog_trans.get_func(func)
print(callable(static_func)) # True
COPY-FROM: paddle.jit.dy2static.program_translator.ProgramTranslator.get_func
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同样要用暴露的 API 名,paddle.jit.ProgramTranslator,即

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@SigureMo
Copy link
Member

SigureMo commented Jul 1, 2023

PaddlePaddle/Paddle#49628

ProgramTranslator 这个 API 已经删了,我说怎么会找不到……

API 文档可以直接删

其余看起来已经成功 COPY 过来了,LGTM

Copy link
Collaborator

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,辛苦~
另外,有两处bug与本pr无关,可以新提一个pr来解决

  1. 在overview页面也同步删除相应信息吧

image

  1. TracedLayerAPI文档都没有copy from成功,可以排查一下问题

@gouzil
Copy link
Member Author

gouzil commented Jul 7, 2023

LGTM,辛苦~ 另外,有两处bug与本pr无关,可以新提一个pr来解决

  1. 在overview页面也同步删除相应信息吧

  2. TracedLayerAPI文档都没有copy from成功,可以排查一下问题

在这个pr一起修了TracedLayer应该是在.. code-block:: python: 多了最后一个冒号

@luotao1 luotao1 merged commit 22ab933 into PaddlePaddle:develop Jul 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants