Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dy2St] Remove deprecated API docs #5870

Merged
merged 7 commits into from
Jul 25, 2023

Conversation

Aurelius84
Copy link
Collaborator

@Aurelius84 Aurelius84 commented May 8, 2023

Remove the following docs:

  • ProgramTranslator
  • TracedLayer

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TracedLayer 也删掉吧

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done

@@ -44,7 +44,7 @@ API 文档
| paddle.io | 数据输入输出相关 API,包括 Dataset、DataLoader 等。 |
+--------------------------+----------------------------------------------------------+
| paddle.jit | 动态图转静态图相关 API,包括 to_static、 |
| | ProgramTranslator、TracedLayer 等。 |
| | not_to_static、save、load 等。 |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

该部分表格没有预览出来。该行右边的|和上一行对齐试试
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done

@@ -49,7 +49,7 @@ In this version, PaddlePaddle has made many optimizations to the APIs. You can r
| | Dataset, and DataLoader |
+-------------------------------+-------------------------------------------------------+
| paddle.jit | Dynamic graph to static graph APIs, including |
| | to_static, ProgramTranslator, TracedLayer, etc. |
| | to_static, not_to_static, save, load, etc. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同样的,表格没有预览出来,该行右边的|和上一行对齐试试

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done

@PaddlePaddle PaddlePaddle deleted a comment from paddle-bot bot May 12, 2023
@SigureMo SigureMo changed the title [Dy2St]Remove deprecate API doc [Dy2St] Remove deprecate API doc Jul 24, 2023
@SigureMo
Copy link
Member

SigureMo commented Jul 24, 2023

@sunzhongkai588 之前没注意到这个 PR,#5983 已经移除了 ProgramTranslator,我们推进下这个 PR 的合入吧(如果遇到 CI 问题我来解决,之前貌似就是卡在 CI 了),把 TracedLayer 给删了,现在 develop TracedLayer COPY-FROM 也是不成功的

image

@@ -42,7 +42,7 @@ function check_style(){
trap 'abort' 0
pre-commit install
commit_files=on
for file_name in `git diff --numstat upstream/$BRANCH| awk '{print $NF}'`;do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原来 CI 没过是因为有 API 被删,这里计算 diff 时候会包含被删的文件,然后传入后续 copy-from 检查时候包含这个文件,然后因为找不到这个文件就挂了

这里修改同:

PaddlePaddle/Paddle#48892 (comment)

利用 git 的 --name-only--diff-filter 来过滤得到需要的文件,这里 ACMR 不包含 deleted file(D),ACMR 详情见上面 PR

这样就不会在检查时候出现找不到文件而导致 CI 挂了~

@sunzhongkai588

@SigureMo SigureMo changed the title [Dy2St] Remove deprecate API doc [Dy2St] Remove deprecated API docs Jul 25, 2023
Copy link
Collaborator

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SigureMo
Copy link
Member

@sunzhongkai588 sunzhongkai588 merged commit 6564508 into PaddlePaddle:develop Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants