[Auto Parallel] fix adapt_stale_fwd_patch for to_static mode #9372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
wawltor
reviewed
Nov 6, 2024
| @@ -167,6 +167,8 @@ def adapt_stale_fwd_patch(self, name, value): | |||
| "StaticFunction" | |||
| ): | |||
| return value | |||
| if type(value).__name__.endswith("WeakMethod") or self.forward.__class__.__name__.endswith("WeakMethod"): | |||
| return value | |||
There was a problem hiding this comment.
对于比较老的paddle版本，这里的修改看起来不兼容？
There was a problem hiding this comment.
对于比较老的paddle版本，这里的修改看起来不兼容？
动转静时，老版本的函数类名叫做 StaticFunction，新版本更新后，这个名字可能是[StaticFunction，WeakMethod]之一。这里的修改其实是兼容老版本的。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
PaddlePaddle/Paddle#68850 的修改导致动转静时，转出来的函数类名称可能变为
WeakMethod，因此需要在 adapt_stale_fwd_patch 这个方法里做对应的适配。