[Dy2St] Use weakref for layer instance conversion to avoid circular reference #68850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
gouzil
previously approved these changes
Oct 21, 2024
zrr1999
previously approved these changes
Oct 21, 2024
…func_to_source_code`
zrr1999
previously approved these changes
Oct 22, 2024
gouzil
previously approved these changes
Oct 22, 2024
gouzil
approved these changes
Oct 23, 2024
SigureMo
deleted the
dy2st/use-weakref-for-layer-instance-convertion-to-avoid-circular-reference
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
要解决的问题同 #68815，但方案不同，本 PR 通过解除 static function 对 class instance 的强引用来解除循环引用
#68815 实现有点恶心，特别是与动态图的边界，以及内部的 API 转换（
convert_call）并不是用to_static而是直接convert_to_static，如果不是StaticFunction就没办法用之前的 bind 方案了，重构起来成本就高了，因此暂时恢复旧的解除引用方案虽然但是，现在的改法也很恶心，
convert_call好恶心closes #68815
PCard-66972