Skip to content

【Hackathon 9th No.5】Add index check for index_sample gpu kernel #74848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

【Hackathon 9th No.5】Add index check for index_sample gpu kernel #74848

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
faaa7d0
Add index check for index_sample gpu kernel
ooooo-create Aug 24, 2025
195cec3
add index check in cpu host
ooooo-create Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions paddle/phi/kernels/gpu/index_sample_kernel.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,12 @@ __global__ void IndexSampleForward(const SampleIndexT* index,
ElementIndexT index_idx = index_j * index_length + index_i;
ElementIndexT in_idx = index_j * input_length + index_i;
SampleIndexT sample_idx = index[index_idx];
PADDLE_ENFORCE(sample_idx >= 0 && sample_idx < input_length,
"Variable value (index) of OP(index_sample) "
"expected >= 0 and < %ld, but got %ld. Please check input "
"value.",
input_length,
sample_idx);
Copy link
Contributor

@DanielSun11 DanielSun11 Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在cuda kernel中添加这些检查是十分不合理的，会影响cuda warp的执行效率，报错时也会产生特别多的重复日志。这部分检查需要想办法转化为在launch cuda kernel之前在CPU侧完成

Copy link
Contributor Author

@ooooo-create ooooo-create Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, 改成 copy 到 cpu 上进行检查了

out_data[index_idx] = in_data[in_idx - index_i + sample_idx];
}
}
Expand Down
Loading