【Hackathon 9th No.5】Add index check for index_sample gpu kernel #74848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
ooooo-create
force-pushed
the
check_index_for_index_sample_gpu
branch
2 times, most recently
from
bd5d73a to
1847aef
Compare
ooooo-create
force-pushed
the
check_index_for_index_sample_gpu
branch
from
1847aef to
faaa7d0
Compare
Contributor
Author
|
/re-run all-failed |
Contributor
请补充下paddleapitest回测的结果。#72637
|
Contributor
Author
done |
DanielSun11
requested changes
Aug 28, 2025
Comment on lines
51
to
56
| PADDLE_ENFORCE(sample_idx >= 0 && sample_idx < input_length, | ||
| "Variable value (index) of OP(index_sample) " | ||
| "expected >= 0 and < %ld, but got %ld. Please check input " | ||
| "value.", | ||
| input_length, | ||
| sample_idx); |
Contributor
There was a problem hiding this comment.
在cuda kernel中添加这些检查是十分不合理的，会影响cuda warp的执行效率，报错时也会产生特别多的重复日志。这部分检查需要想办法转化为在launch cuda kernel之前在CPU侧完成
Contributor
Author
There was a problem hiding this comment.
Done, 改成 copy 到 cpu 上进行检查了
Contributor
Author
|
/re-run all-failed |
Contributor
|
close due to the following PR is merged: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Operator Mechanism
PR Types
Bug fixes
Description
Add index check for index_sample gpu kernel