Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【PIR OpTest Fix No.12】 Fix test_partial_sum_op #62783

Merged
merged 8 commits into from
Mar 20, 2024
Merged

【PIR OpTest Fix No.12】 Fix test_partial_sum_op #62783

merged 8 commits into from
Mar 20, 2024

Conversation

cmcamdy
Copy link
Contributor

@cmcamdy cmcamdy commented Mar 16, 2024 •
edited
Loading

PR Category

Others

PR types

Others

Description

PIR Op单测修复
修复单测 test_partial_sum_op
修复后打开FLAGS_enable_pir_in_executor单测是否通过：是

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Mar 16, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Mar 16, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

cmcandy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@paddle-bot paddle-bot bot added the contributor External developers label Mar 16, 2024
@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Mar 16, 2024

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@cmcamdy cmcamdy closed this Mar 17, 2024
@cmcamdy cmcamdy reopened this Mar 17, 2024
SigureMo
SigureMo reviewed Mar 17, 2024
View reviewed changes
paddle/fluid/ir_adaptor/translator/op_translator.cc Outdated
std::string target_op_name = "pd_op.partial_sum";
const auto& op_info = ctx->GetRegisteredOpInfo(target_op_name);
if (!op_info) {
IR_THROW(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注意一下，我们在全面替换 IR_THROW（#62748），这里可以考虑改成 PADDLE_THROW

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

行，这个文件我都改一下把

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要看看这个文件是否有人在 #62748 认领，如果没人认领可以认领一下再改，不要重复修改了，另外建议全量修改在单独 PR 做

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OKK，刚看有人领了，我就暂时把我自己的改了

@luotao1 luotao1 mentioned this pull request Mar 18, 2024
Closed
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Mar 18, 2024
kangguangli
kangguangli reviewed Mar 18, 2024
View reviewed changes
Copy link
Contributor

@kangguangli kangguangli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其他地方没什么问题，如无特殊支持，去掉op_translator里的PartialSumOpTranscriber即可。

paddle/fluid/ir_adaptor/translator/op_translator.cc Outdated Show resolved Hide resolved
@kangguangli kangguangli merged commit 7def47f into PaddlePaddle:develop Mar 20, 2024
30 checks passed
@luotao1
Copy link
Contributor

luotao1 commented Mar 20, 2024

hi, @cmcamdy

  • 非常感谢你对飞桨的贡献，我们正在运营一个PFCC组织，会通过定期分享技术知识与发布开发者主导任务的形式持续为飞桨做贡献，详情可见 https://github.com/luotao1 主页说明。
  • 如果你对PFCC有兴趣，请发送邮件至 [email protected]，我们会邀请你加入~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo left review comments

@zyfncg zyfncg zyfncg approved these changes

@kangguangli kangguangli kangguangli approved these changes

Assignees

@luotao1 luotao1

@kangguangli kangguangli

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cmcamdy @CLAassistant @luotao1 @zyfncg @kangguangli @SigureMo