-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【PIR OpTest Fix No.12】 Fix test_partial_sum_op #62783
Conversation
[PIR] Fix test_partial_sum_op
你的PR提交成功,感谢你对开源项目的贡献! |
cmcandy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
❌ The PR is not created using PR's template. You can refer to this Demo. |
std::string target_op_name = "pd_op.partial_sum"; | ||
const auto& op_info = ctx->GetRegisteredOpInfo(target_op_name); | ||
if (!op_info) { | ||
IR_THROW( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
注意一下,我们在全面替换 IR_THROW(#62748),这里可以考虑改成 PADDLE_THROW
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
行,这个文件我都改一下把
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
需要看看这个文件是否有人在 #62748 认领,如果没人认领可以认领一下再改,不要重复修改了,另外建议全量修改在单独 PR 做
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OKK,刚看有人领了,我就暂时把我自己的改了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
其他地方没什么问题,如无特殊支持,去掉op_translator里的PartialSumOpTranscriber即可。
hi, @cmcamdy
|
PR Category
Others
PR types
Others
Description
PIR Op单测修复
修复单测 test_partial_sum_op
修复后打开FLAGS_enable_pir_in_executor单测是否通过:是