Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【快乐开源】报错日志体系优化 #62748

Closed
Galaxy1458 opened this issue Mar 15, 2024 · 8 comments
Closed

【快乐开源】报错日志体系优化 #62748

Galaxy1458 opened this issue Mar 15, 2024 · 8 comments
Assignees
Labels
HappyOpenSource 快乐开源活动issue与PR status/close 已关闭 type/others 其他问题

Comments

@Galaxy1458
Copy link
Contributor

Galaxy1458 commented Mar 15, 2024

问题描述 Please describe your issue

一、需求背景

目前飞桨中IR_ENFORCE|CHECK_EQ|CHECK_NE|CHECK_LT|CHECK_LE|CHECK_GE|CHECK_GT|LOG(FATAL)等宏的使用缺乏规范性,目前打算将其全部替换为 PADDLE_THROW(phi::errors::xxx()) or PADDLE_ENFORCE_xx ,其中xx对应某种条件,xxx对应某种错误类型,具体见建议步骤。如果报错信息中出现了phi::errors,同步替换为common::errors,如下:
13ff44fc02180ca7cdabc6c188bd5dec

二、参考文档和示例PR

三、任务划分

清单见:https://doc.weixin.qq.com/sheet/e3_AakAbwboADEAkkHNPvLRFSVu8Cag4?scode=AHAA0Qc9AFoDLrIHbI

  • 第一批:需要将 CHECK_*宏全部替换为PADDLE_ENFORCE_xx
  • 第二批:需要将 CHECK宏全部替换为PADDLE_ENFORCE_xx
  • 第三批: 需要将 IRScheduleErrorHandler宏全部替换为PADDLE_ENFORCE_xx ,并删除原来的函数

认领方式

请大家直接在👆的excel表中认领任务,如:

  • PR 提交格式:在 PR 的标题中以 【Error Message No. xxx】 开头,注明任务编号
  • 认领后,超过2周没有提交PR,将重新释放

已完成的表: 其中 1~ 10为IR_ENFORCE, 11 ~ 35为CHECK_*, 36为IRScheduleErrorHandler

序号 文件名 认领人/状态/PR号
1 paddle/fluid/ir_adaptor/translator/* @enkilee #62768
2 paddle/fluid/pir/dialect/op_generator/* @enkilee #62773
3 paddle/fluid/pir/dialect/operator/* @enkilee #62775
4 paddle/fluid/pir/transforms/* @enkilee #62814 #62840
5 paddle/pir/include/* @enkilee
6 paddle/pir/src/core/*
7 paddle/pir/src/dialect/*
8 paddle/pir/src/pass/*
9 paddle/pir/src/pattern_rewrite/*
10 test/*
11 paddle/cinn/adt/*
12 paddle/cinn/ast_gen_ius/* @shuaihehe #63301
13 paddle/cinn/auto_schedule/* @successfulbarrier
14 paddle/cinn/backends/*
15 paddle/cinn/common/*
16 paddle/cinn/frontend/.cc,.h @enkilee #63157
17 paddle/cinn/frontend/decomposer/* @Liyulingyue #62774
@enkilee #64310
18 paddle/cinn/frontend/op_mappers/*
19 paddle/cinn/frontend/paddle/* @shuaihehe #63580
20 paddle/cinn/frontend/pass/* @shuaihehe #64382
21 paddle/cinn/hlir/dialect/* @shuaihehe #63273
22 paddle/cinn/hlir/framework/*
23 paddle/cinn/hlir/op/* @Jeff114514 #66455
24 paddle/cinn/hlir/pass/*
25 paddle/cinn/hlir/pe/*
26 paddle/cinn/ir/*
27 paddle/cinn/lang/* @shuaihehe #62973
28 paddle/cinn/optim/* @shuaihehe #63046
29 paddle/cinn/poly/*
30 paddle/cinn/pybind/* @shuaihehe #63193
31 paddle/cinn/runtime/* , paddle/cinn/utils @jinyouzhi #63004 #63039
32 paddle/fluid/framework/, paddle/fluid/distributed/ps/table/
33 paddle/fluid/inference/* @Caogration #66452
34 paddle/phi*, paddle/pir* @jinyouzhi #62861 #62886
35 test/*
36 paddle/cinn/ir/schedule/impl/*

看板信息

任务方向 任务数量 提交作品 / 任务认领 提交率 完成 完成率
快乐开源 35 17 / 19 48.57% 14 40.0%

统计信息

排名不分先后 @enkilee (5) @shuaihehe (7) @Liyulingyue (1) @jinyouzhi (1)

@Galaxy1458 Galaxy1458 changed the title 【快乐开源】 【快乐开源】报错体系优化 Mar 15, 2024
@Galaxy1458 Galaxy1458 changed the title 【快乐开源】报错体系优化 【快乐开源】报错日志体系优化 Mar 15, 2024
@luotao1 luotao1 assigned luotao1 and Galaxy1458 and unassigned winter-wang Mar 15, 2024
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Mar 15, 2024
@enkilee
Copy link
Contributor

enkilee commented Mar 15, 2024

【报名】:1-5

@jinyouzhi
Copy link
Contributor

【报名】:34

@shuaihehe
Copy link
Contributor

【报名】:27、28、30

@jinyouzhi
Copy link
Contributor

【报名】:31

@shuaihehe
Copy link
Contributor

【报名】:21

@luotao1 luotao1 closed this as completed Sep 26, 2024
@paddle-bot paddle-bot bot added status/close 已关闭 and removed status/new-issue 新建 labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HappyOpenSource 快乐开源活动issue与PR status/close 已关闭 type/others 其他问题
Projects
Development

No branches or pull requests

8 participants