-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【快乐开源】报错日志体系优化 #62748
Labels
Comments
Open
【报名】:1-5 |
This was referenced Mar 16, 2024
This was referenced Mar 18, 2024
【报名】:34 |
【报名】:27、28、30 |
【报名】:31 |
【报名】:21 |
This was referenced Jul 29, 2024
This was referenced Jul 29, 2024
This was referenced Jul 29, 2024
Merged
This was referenced Jul 31, 2024
This was referenced Jul 31, 2024
This was referenced Aug 5, 2024
This was referenced Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
问题描述 Please describe your issue
一、需求背景
目前飞桨中
IR_ENFORCE|CHECK_EQ|CHECK_NE|CHECK_LT|CHECK_LE|CHECK_GE|CHECK_GT|LOG(FATAL)
等宏的使用缺乏规范性,目前打算将其全部替换为PADDLE_THROW(phi::errors::xxx()) or PADDLE_ENFORCE_xx
,其中xx
对应某种条件,xxx
对应某种错误类型,具体见建议步骤。如果报错信息中出现了phi::errors,同步替换为common::errors,如下:二、参考文档和示例PR
三、任务划分
清单见:https://doc.weixin.qq.com/sheet/e3_AakAbwboADEAkkHNPvLRFSVu8Cag4?scode=AHAA0Qc9AFoDLrIHbI
CHECK_*
宏全部替换为PADDLE_ENFORCE_xx
CHECK
宏全部替换为PADDLE_ENFORCE_xx
IRScheduleErrorHandler
宏全部替换为PADDLE_ENFORCE_xx
,并删除原来的函数认领方式
请大家直接在👆的excel表中认领任务,如:
已完成的表: 其中 1~ 10为
IR_ENFORCE
, 11 ~ 35为CHECK_*
, 36为IRScheduleErrorHandler
paddle/pir/include/*paddle/pir/src/core/*paddle/pir/src/dialect/*paddle/pir/src/pass/*paddle/pir/src/pattern_rewrite/*test/*@enkilee #64310
看板信息
统计信息
The text was updated successfully, but these errors were encountered: