[PIR] remove add_custom_target in pir codegen of CMakeLists.txt #59222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
…lePaddle#59222) * initial modifying * fix error for copy_if_different * add add gitignore * modify paddle/cinn/hlir/dialect/operator/ir/CMakeLists.txt * modify gitignore * fix * polish * remove include_directories(${CMAKE_CURRENT_BINARY_DIR}) * revert delete include_directories(${CMAKE_CURRENT_BINARY_DIR}) * fix * revert ops_api_gen
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
在 #59129 里将 pir 相关的代码生成从 make 编译阶段移动至了 cmake 构建阶段，
因此此时在 paddle/fluid/pir/dialect/CMakeLists.txt 中没有了 add_custom_command 相关命令。在没有显式指明 target 和没有其他 target 依赖该 target 时，命令不会执行。所以除了
ops_api_gen，将其他的 add_custom_target 从 paddle/fluid/pir/dialect/CMakeLists.txt 中删除