[PIR] move pir, hlir code generating from make stage to cmake stage #59129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
MarioLulab
changed the title
zhangbo9674
reviewed
Nov 21, 2023
| endif() | ||
| endforeach() | ||
|
|
||
| add_custom_target( |
There was a problem hiding this comment.
收到。当前 pr 先推动合入，后续完善
zhangbo9674
approved these changes
Nov 21, 2023
MarioLulab
changed the title
This was referenced Nov 21, 2023
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
…addlePaddle#59129) * initial modifying * fix error for copy_if_different * add add gitignore * modify paddle/cinn/hlir/dialect/operator/ir/CMakeLists.txt * modify gitignore * fix * polish * remove include_directories(${CMAKE_CURRENT_BINARY_DIR}) * revert delete include_directories(${CMAKE_CURRENT_BINARY_DIR})
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
主要工作
将
paddle/fluid/pir/dialect/CMakeLists.txt的代码生成逻辑从 build 阶段放到 cmake 阶段，由 cmake 生成对应的pd_op.h
pd_op.cc
pd_op_vjp.cc
pd_api.h
pd_api.cc
static_op_function.h
static_op_function.cc
ops_api.cc
将
paddle/cinn/hlir/dialect/operator/ir/CMakeLists.txt的代码生成逻辑从 build 阶段放到 cmake 阶段，由 cmake 生成对应的ops.parsed.yaml
cinn_op.cc
cinn_op.h
存在风险：
没有改变 include 的路径，使得增量编译存在新老两个自动生成的头文件时，一个存在于 source 路径下，一个存在于 build 路径下，若不清理 build/paddle/fluid/pir 和 build/paddle/cinn 目录，会错误的引用老的头文件(即 build/ 目录下的头文件)。例如：
进而产生变量未声明的编译错误