[AMP_OP&Test] improve FP16 and BF16 OpTest for maximum, minimum and multiply op #52256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
FlyingQianMM
force-pushed
the
develop_amp
branch
4 times, most recently
from
8ccd912
to
be08bd8
Compare
FlyingQianMM
force-pushed
the
develop_amp
branch
from
be08bd8
to
bd3d48d
Compare
ZzSean
reviewed
Mar 30, 2023
| @@ -178,31 +246,13 @@ def setUp(self): | |||
|
|
|||
| def test_check_output(self): | |||
| if hasattr(self, 'attrs'): | |||
| self.check_output(check_dygraph=False) | |||
| self.check_output(check_dygraph=False, atol=1e-2) | |||
ZzSean
reviewed
Mar 30, 2023
|
|
||
| def test_check_grad_normal(self): | ||
| if hasattr(self, 'attrs'): | ||
| # check_prim=False, bfloat16 is not supported in `less_equal` | ||
| self.check_grad(['X', 'Y'], 'Out', check_dygraph=False) |
There was a problem hiding this comment.
这部分代码是多余的，因为已修改为继承TestElementwiseFP16Op
ZzSean
reviewed
Mar 30, 2023
ZzSean
reviewed
Mar 30, 2023
| @@ -61,6 +60,36 @@ def test_check_grad_ingore_y(self): | |||
| ) | |||
|
|
|||
|
|
|||
| class TestElementwiseFP16Op(TestElementwiseOp): | |||
| def setUp(self): | |||
| self.op_type = "elementwise_min" | |||
ZzSean
reviewed
Mar 30, 2023
| self.outputs = {'Out': np.minimum(self.inputs['X'], self.inputs['Y'])} | ||
|
|
||
| def test_check_output(self): | ||
| self.check_output(atol=1e-3) |
ZzSean
reviewed
Mar 30, 2023
| @@ -150,16 +150,30 @@ def setUp(self): | |||
| self.if_enable_cinn() | |||
|
|
|||
| def test_check_output(self): | |||
| self.check_output() | |||
| self.check_output(atol=1e-2) | |||
FlyingQianMM
force-pushed
the
develop_amp
branch
from
58255af
to
4b78cda
Compare
FlyingQianMM
changed the title
FlyingQianMM
changed the title
luotao1
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe