[AMP OP&Test] Append bf16/fp16 support 4 elementwise_max #51151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Vvsmile
reviewed
Mar 7, 2023
| @@ -120,9 +120,13 @@ def test_check_output(self): | |||
|
|
|||
| def test_check_grad_normal(self): | |||
| if hasattr(self, 'attrs'): | |||
| self.check_grad(['X', 'Y'], 'Out', check_eager=False) | |||
| self.check_grad( | |||
| ['X', 'Y'], 'Out', numeric_grad_delta=0.01, check_eager=False | |||
Vvsmile
reviewed
Mar 13, 2023
| ) | ||
|
|
||
|
|
||
| class TestElementwiseFP16Op(TestElementwiseOp): |
There was a problem hiding this comment.
改一下类名，用TestElementwiseMaxFP16Op代替
Vvsmile
reviewed
Mar 13, 2023
| @@ -131,6 +178,53 @@ def test_check_grad_ingore_y(self): | |||
| self.check_grad(['X'], 'Out', no_grad_set=set('Y')) | |||
|
|
|||
|
|
|||
| class TestElementwiseMaxBF16Op_ZeroDim1(TestElementwiseBF16Op): | |||
| def setUp(self): | |||
There was a problem hiding this comment.
很多子类的setUp都复用了基类的一些代码，建议不同点用init_data等函数单独提取出来，减少重复代码
|
PR的Describe里面请多补充FP16/BF16/API Check已在其他PR中完成，以及不同于规范的点及原因，如FP16中max_relative_error=0.005及BF16中delta=0.05 |
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe