Fix bug for prepare phi OP #40033
Merged
Fix bug for prepare phi OP #40033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zyfncg
approved these changes
Mar 2, 2022
chenwhql
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Describe
PR #38979 adds some codes in prepared_operatoer.cc that reacquires a CPU DeviceContext from the DeviceContextPool when the expected_kernel_key.place_ is CPU place. This cannot handle all situations. When the expected_kernel_key.place_ is GPU place and the place parameter for PreparedImpl is CPU place, the DeviceContext also need to be reacquired, or a CPU DeviceContext will pass to a GPU kernel.
This bug is triggered after moving Compare OPs to phi in PR #39970 , which causes a random segmentation fault in case test_where.py in CE:
This PR fixes this bug.