-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PTEN] Add cpu context #38979
Merged
Merged
[PTEN] Add cpu context #38979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution! |
jim19930609
reviewed
Jan 20, 2022
jim19930609
previously approved these changes
Jan 20, 2022
chenwhql
previously approved these changes
Jan 20, 2022
Avin0323
previously approved these changes
Jan 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for PR-CI-OP-benchmark
jiweibo
dismissed stale reviews from Avin0323, chenwhql, and jim19930609
via
January 20, 2022 02:38
ce9623e
jim19930609
approved these changes
Jan 20, 2022
Avin0323
approved these changes
Jan 20, 2022
chenwhql
approved these changes
Jan 20, 2022
raindrops2sea
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
该pr改动总结如下:
1、platform::DeviceContext 移动到 pten::DeviceContext
2、添加 pten::CPUContext
3、platform::CPUDeviceContext 继承 pten::CPUContext
4、CpuContext适配过程中对现有框架的修改
Note(TODO):
1、pten::DeviceContext::Alloc接口暂未实现,待TensorBase提供相关接口后添加;参考pr #39022 添加实现
2、pten::DeviceContext::GetPlace接口需评估是否需要删除以及如何删除,pten内部mutable_data以及storage仍然在用GetPlace接口;
3、pten::DeviceContext::Wait接口,在fluid框架内多处用到,无法删除,目前保留在pten::DeviceContext中。
4、如不需删除GetPlace接口,则后续会使用using platform::CPUDeviceContext=pten::CPUContext。