Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cherry-pick] Add return self for nn.Layer #36779

Closed
wants to merge 2 commits into from
Closed

[Cherry-pick] Add return self for nn.Layer #36779

wants to merge 2 commits into from

Conversation

zh794390558
Copy link
Contributor

@zh794390558 zh794390558 commented Oct 27, 2021 •
edited
Loading

PR types

Bug fixes

PR changes

APIs

Describe

Layer.to return self
cherry pick to 2.2 same to :
#36609

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zh794390558 zh794390558 changed the base branch from develop to release/2.2 October 27, 2021 07:30
ZeyuChen
ZeyuChen approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@ZeyuChen ZeyuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZeyuChen ZeyuChen changed the title [BUGFIX] Add return self for nn.Layer [Cherry-pick] Add return self for nn.Layer Oct 27, 2021
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Oct 27, 2021
@PaddlePaddle PaddlePaddle unlocked this conversation Oct 27, 2021
@paddle-bot-old
Copy link

paddle-bot-old bot commented Nov 4, 2021

Sorry to inform you that 36a90e7's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@MingMingShangTian MingMingShangTian mentioned this pull request Dec 14, 2021
Merged
lanxianghit pushed a commit that referenced this pull request Dec 15, 2021
@MingMingShangTian
[cherry-pick]layer.to api support numpy.dtype and paddle.dtype (#38108)
8100c16 
Issue37932 反馈 layer.to 不支持paddle.dtype类型的问题，新增了对这类型的支持。详情见：#38018
同时，也一并cherry-pick了遗漏的 PR 36779 的commit。

修改内容：
Cherry-pick #36779
cherrry-pick #38018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeyuChen ZeyuChen ZeyuChen approved these changes

@TCChenlong TCChenlong TCChenlong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zh794390558 @ZeyuChen @TCChenlong @MingMingShangTian