Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Add return self for nn.Layer #36609

Merged
merged 2 commits into from
Oct 27, 2021
Merged

[BUGFIX] Add return self for nn.Layer #36609

merged 2 commits into from
Oct 27, 2021

Conversation

zh794390558
Copy link
Contributor

@zh794390558 zh794390558 commented Oct 21, 2021 •
edited
Loading

PR types

Bug fixes

PR changes

APIs

Describe

Layer.to return self

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zh794390558 zh794390558 changed the title [bugfix] Layer.to reutrn self same to torch [bugfix] Layer.to return self same to torch Oct 21, 2021
ZeyuChen
ZeyuChen approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@ZeyuChen ZeyuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhiqiu
zhiqiu approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZeyuChen ZeyuChen changed the title [bugfix] Layer.to return self same to torch [BUGFIX] Add return self for nn.Layer Oct 27, 2021
@ZeyuChen ZeyuChen merged commit facf602 into PaddlePaddle:develop Oct 27, 2021
@zh794390558 zh794390558 mentioned this pull request Oct 27, 2021
Closed
ghost pushed a commit to piotrekobi/Paddle that referenced this pull request Nov 3, 2021
@zh794390558 @piotrekobi
[BUGFIX] Add return self for nn.Layer(PaddlePaddle#36609)
c12d1e3 
* Layer.to reutrn self

* add device required
MingMingShangTian pushed a commit to MingMingShangTian/Paddle that referenced this pull request Dec 14, 2021
@zh794390558 @MingMingShangTian
[BUGFIX] Add return self for nn.Layer(PaddlePaddle#36609)
56aa770 
* Layer.to reutrn self

* add device required
@zh794390558 zh794390558 deleted the layer_to branch April 7, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeyuChen ZeyuChen ZeyuChen approved these changes

@zhiqiu zhiqiu zhiqiu approved these changes

@TCChenlong TCChenlong TCChenlong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zh794390558 @ZeyuChen @zhiqiu @TCChenlong